Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc version upgrade #13105

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

solc version upgrade #13105

wants to merge 2 commits into from

Conversation

AmadiMichael
Copy link
Member

Description

Bump the SOLC version of all OP stack contracts from 0.8.15 and 0.8.19 to 0.8.25.
Also involves updating the lib-keccak dependency to the latest that has a loose pragma version of ^0.8.0 and not a strict 0.8.15.

Metadata

@AmadiMichael AmadiMichael requested a review from a team as a code owner November 26, 2024 17:43
@maurelian maurelian self-requested a review November 26, 2024 19:07
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.34%. Comparing base (4ee839a) to head (a8e3e34).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-chain-ops/script/cheatcodes_external.go 58.82% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13105      +/-   ##
===========================================
- Coverage    44.51%   44.34%   -0.17%     
===========================================
  Files          801      801              
  Lines        72026    72035       +9     
===========================================
- Hits         32059    31942     -117     
- Misses       37359    37487     +128     
+ Partials      2608     2606       -2     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/script/cheatcodes_external.go 14.20% <58.82%> (+0.21%) ⬆️

... and 17 files with indirect coverage changes

@tynes
Copy link
Contributor

tynes commented Nov 26, 2024

                Error Trace:    /var/opt/circleci/data/workdir/op-e2e/interop/supersystem.go:194
                                                        /var/opt/circleci/data/workdir/op-e2e/interop/supersystem.go:537
                                                        /var/opt/circleci/data/workdir/op-e2e/interop/supersystem.go:129
                                                        /var/opt/circleci/data/workdir/op-e2e/interop/interop_test.go:42
                                                        /var/opt/circleci/data/workdir/op-e2e/interop/interop_test.go:319
                Error:          Received unexpected error:
                                failed to deploy superchain to L1: failed to deploy Superchain contracts: failed to run DeploySuperchain script: revert: failed to run GetCode, ABI: "getCode(string)", err: failed to open artifact "forge-artifacts/Proxy.sol/Proxy.json.sol/forge-artifacts/Proxy.sol/Proxy.json.json": open forge-artifacts/Proxy.sol/Proxy.json.sol/forge-artifacts/Proxy.sol/Proxy.json.json: no such file or directory

There may also be an issue running this on older forks of op stack, ie before PUSH0 was supported

@smartcontracts smartcontracts force-pushed the sc/solc-upgrade branch 2 times, most recently from 58295d2 to db3fe2d Compare December 2, 2024 15:01
@smartcontracts smartcontracts requested review from a team as code owners December 2, 2024 15:01
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Feb 20, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-stale Status: Will be closed unless there is activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM Engineering: Update all 0.8.15 code to 0.8.25
5 participants