Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move interfaces to a new top-level folder #13114

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

smartcontracts
Copy link
Contributor

Moves all contract interfaces to a new top-level folder. Keeps things much cleaner and more sane for a future auto-generated interface system.

@smartcontracts smartcontracts requested review from a team as code owners November 27, 2024 01:47
@smartcontracts smartcontracts force-pushed the sc/top-level-interfaces branch from 505b745 to ce00f46 Compare November 27, 2024 01:50
@smartcontracts smartcontracts requested a review from a team as a code owner November 27, 2024 01:50
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (c3e535c) to head (6cec8a8).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13114      +/-   ##
===========================================
- Coverage    44.35%   44.18%   -0.17%     
===========================================
  Files          807      807              
  Lines        72707    72707              
===========================================
- Hits         32247    32125     -122     
- Misses       37831    37960     +129     
+ Partials      2629     2622       -7     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@smartcontracts smartcontracts force-pushed the sc/top-level-interfaces branch 2 times, most recently from 11225ca to 4d99a8f Compare November 27, 2024 02:59
@tynes
Copy link
Contributor

tynes commented Nov 27, 2024

This is going to make a giant headache for open PRs that will need a rebase (standard L2 genesis)

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scrolled through the whole diff!

@maurelian maurelian added the M-do-not-merge Meta: Do not merge label Nov 27, 2024
@maurelian
Copy link
Contributor

This is going to make a giant headache for open PRs that will need a rebase (standard L2 genesis)

Going to leave my approval on, but applied the do-not-merge label to address this discussion.

IMO we should not continue to disrupt dev momentum for the L2 standard genesis work which is in limbo and going into a new discovery/scoping phase next week.

@smartcontracts
Copy link
Contributor Author

IMO we should not continue to disrupt dev momentum for the L2 standard genesis work which is in limbo and going into a new discovery/scoping phase next week.

I'll push back on this. We have no guarantees about the timeline for the L2 genesis work and that PR has already blocked changes on the basis of rebasing for almost a month now.

@smartcontracts
Copy link
Contributor Author

This is going to make a giant headache for open PRs that will need a rebase (standard L2 genesis)

Standard L2 genesis is the only one that's really impacted by this and we have no idea how long it's going to take to be merged at this point. I feel strongly that we should bite the bullet and start being able to get work done on the contracts again. I can personally handle the rebasing process if others don't want to.

@smartcontracts smartcontracts force-pushed the sc/top-level-interfaces branch from 4d99a8f to 1ffd634 Compare December 4, 2024 17:28
@maurelian maurelian removed the M-do-not-merge Meta: Do not merge label Dec 4, 2024
@maurelian maurelian enabled auto-merge December 4, 2024 17:30
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops changes lgtm

Moves all contract interfaces to a new top-level folder. Keeps
things much cleaner and more sane for a future auto-generated
interface system.
@smartcontracts smartcontracts force-pushed the sc/top-level-interfaces branch from 1ffd634 to 6cec8a8 Compare December 4, 2024 17:40
@maurelian maurelian added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit ec05937 Dec 4, 2024
44 checks passed
@maurelian maurelian deleted the sc/top-level-interfaces branch December 4, 2024 18:54
@smartcontracts smartcontracts mentioned this pull request Dec 5, 2024
31 tasks
sigma pushed a commit that referenced this pull request Dec 19, 2024
Moves all contract interfaces to a new top-level folder. Keeps
things much cleaner and more sane for a future auto-generated
interface system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants