-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move interfaces to a new top-level folder #13114
Conversation
505b745
to
ce00f46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13114 +/- ##
===========================================
- Coverage 44.35% 44.18% -0.17%
===========================================
Files 807 807
Lines 72707 72707
===========================================
- Hits 32247 32125 -122
- Misses 37831 37960 +129
+ Partials 2629 2622 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
11225ca
to
4d99a8f
Compare
This is going to make a giant headache for open PRs that will need a rebase (standard L2 genesis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scrolled through the whole diff!
Going to leave my approval on, but applied the do-not-merge label to address this discussion. IMO we should not continue to disrupt dev momentum for the L2 standard genesis work which is in limbo and going into a new discovery/scoping phase next week. |
I'll push back on this. We have no guarantees about the timeline for the L2 genesis work and that PR has already blocked changes on the basis of rebasing for almost a month now. |
Standard L2 genesis is the only one that's really impacted by this and we have no idea how long it's going to take to be merged at this point. I feel strongly that we should bite the bullet and start being able to get work done on the contracts again. I can personally handle the rebasing process if others don't want to. |
4d99a8f
to
1ffd634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops changes lgtm
Moves all contract interfaces to a new top-level folder. Keeps things much cleaner and more sane for a future auto-generated interface system.
1ffd634
to
6cec8a8
Compare
Moves all contract interfaces to a new top-level folder. Keeps things much cleaner and more sane for a future auto-generated interface system.
Moves all contract interfaces to a new top-level folder. Keeps things much cleaner and more sane for a future auto-generated interface system.