use CallContract to detect tx failure early if gasLimit is specified
#13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize 4a539aa |
|
@Inphi Looks like the CI failure is unrelated to this PR? |
|
@zhiqiangxu Could you try merging from the latest develop? |
Done. |
|
/ci authorize 9c010a7 |
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 29, 2024
8118fff
46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
gasLimitis specified inTxCandidate,EstimateGaswill be called, which does 2 jobs in one shot:But if
gasLimitis specified, there's no such checking.This PR adds a checking by
CallContractifgasLimitis specified.