Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txmgr: Queue.Send() uses q.txMgr.SendAsync #13120

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Nov 27, 2024

This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.

Description

Updates the txMgr Queue.Send() entrypoint to use txMgr.SendAsync()

Tests

See #13124

Additional context

Since Holocene, the order of batches landing on chain must be strictly adhered to. The batcher has been hardened to keep batches ordered before they get to the txMgr, but the txMgr fails to preserve the order of txs that the batcher sends to it. This caused a safe head stall on Base Sepolia.

The changes here also affect op-challenger.

Metadata

Fixes #12947

This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.
@geoknee geoknee requested a review from a team as a code owner November 27, 2024 10:38
@geoknee geoknee requested a review from blmalone November 27, 2024 10:38
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.74%. Comparing base (72eb311) to head (8c06a80).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13120      +/-   ##
===========================================
- Coverage    44.46%   42.74%   -1.73%     
===========================================
  Files          798      742      -56     
  Lines        71682    67028    -4654     
===========================================
- Hits         31874    28648    -3226     
+ Misses       37224    35977    -1247     
+ Partials      2584     2403     -181     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-service/txmgr/queue.go 82.75% <100.00%> (+4.03%) ⬆️

... and 63 files with indirect coverage changes

It doesn't preserve the nonces like the production txMgr does.
@geoknee geoknee requested a review from a team as a code owner November 27, 2024 11:10
@geoknee geoknee requested a review from clabby November 27, 2024 11:10
@geoknee geoknee marked this pull request as draft November 27, 2024 12:02
@geoknee geoknee added the A-op-batcher Area: op-batcher label Nov 27, 2024
@geoknee geoknee marked this pull request as ready for review November 27, 2024 16:48
op-service/txmgr/queue.go Outdated Show resolved Hide resolved
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here also affect op-challenger.

I think this change is fine for op-challenger, but will defer to @ajsutton

@geoknee geoknee added this pull request to the merge queue Nov 28, 2024
Merged via the queue into develop with commit 26f7a40 Nov 28, 2024
45 checks passed
@geoknee geoknee deleted the gk/txmgr-queue-send-async branch November 28, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-batcher Area: op-batcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txmgr: use sendAsync in Queue
5 participants