-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txmgr: Queue.Send()
uses q.txMgr.SendAsync
#13120
Conversation
This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13120 +/- ##
===========================================
- Coverage 44.46% 42.74% -1.73%
===========================================
Files 798 742 -56
Lines 71682 67028 -4654
===========================================
- Hits 31874 28648 -3226
+ Misses 37224 35977 -1247
+ Partials 2584 2403 -181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It doesn't preserve the nonces like the production txMgr does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here also affect op-challenger.
I think this change is fine for op-challenger
, but will defer to @ajsutton
This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.
Description
Updates the txMgr
Queue.Send()
entrypoint to usetxMgr.SendAsync()
Tests
See #13124
Additional context
Since Holocene, the order of batches landing on chain must be strictly adhered to. The batcher has been hardened to keep batches ordered before they get to the txMgr, but the txMgr fails to preserve the order of txs that the batcher sends to it. This caused a safe head stall on Base Sepolia.
The changes here also affect
op-challenger
.Metadata
Fixes #12947