Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: Remove unused install-geth target #13130

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Nov 27, 2024

A locally installed geth has not been required to run a local devnet or for op-e2e for some time now.
Geth is still used in docker environments, but the user shouldn't be forced to install it locally.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.68%. Comparing base (9109958) to head (0da437a).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13130      +/-   ##
===========================================
- Coverage    44.46%   42.68%   -1.79%     
===========================================
  Files          798      742      -56     
  Lines        71682    67017    -4665     
===========================================
- Hits         31876    28605    -3271     
+ Misses       37219    36002    -1217     
+ Partials      2587     2410     -177     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 68 files with indirect coverage changes

@Inphi Inphi marked this pull request as ready for review November 27, 2024 20:43
@Inphi Inphi requested review from a team as code owners November 27, 2024 20:43
@Inphi Inphi requested a review from sebastianst November 27, 2024 20:43
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank god this make target is so annoying

@mslipper mslipper added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 2bbfd5d Nov 27, 2024
45 checks passed
@mslipper mslipper deleted the inphi/remove-geth-check branch November 27, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants