Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mips contracts stack too deep errors #13137

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

AmadiMichael
Copy link
Member

fix mips contracts stack too deep errors

@AmadiMichael AmadiMichael requested a review from a team as a code owner November 28, 2024 13:54
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (e84868c) to head (16da642).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13137       +/-   ##
============================================
+ Coverage    44.42%   66.77%   +22.35%     
============================================
  Files          801       56      -745     
  Lines        72001     4665    -67336     
============================================
- Hits         31983     3115    -28868     
+ Misses       37402     1378    -36024     
+ Partials      2616      172     -2444     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 753 files with indirect coverage changes

@smartcontracts smartcontracts requested a review from Inphi November 30, 2024 15:58
@smartcontracts
Copy link
Contributor

Would be great to get a review from either @Inphi or @mbaxter

@Inphi Inphi added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit a486dae Dec 2, 2024
45 checks passed
@Inphi Inphi deleted the sc/fix-mips-stack-too-deep branch December 2, 2024 17:07
@smartcontracts smartcontracts mentioned this pull request Dec 2, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants