fix: stack too deep in PermissionedDisputeGame #13141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13141 +/- ##
============================================
- Coverage 58.54% 42.81% -15.74%
============================================
Files 63 745 +682
Lines 5848 67352 +61504
============================================
+ Hits 3424 28836 +25412
- Misses 2219 36085 +33866
- Partials 205 2431 +2226
Flags with carried forward coverage won't be shown. Click here to find out more. |
smartcontracts
force-pushed
the
sc/fdg-stack-too-deep
branch
from
505c447 to
0ffd902
Compare
packages/contracts-bedrock/src/dispute/interfaces/IPermissionedDisputeGame.sol
Outdated
Show resolved
Hide resolved
smartcontracts
force-pushed
the
sc/fdg-stack-too-deep
branch
from
0ffd902 to
fdcd37c
Compare
Fixes the stack-too-deep error in the PermissionedDisputeGame by updating the game to use a struct as the constructor parameter.
smartcontracts
force-pushed
the
sc/fdg-stack-too-deep
branch
from
fdcd37c to
d50e92f
Compare
AmadiMichael
approved these changes
Dec 1, 2024
clabby
approved these changes
Dec 2, 2024
31 tasks
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
Fixes the stack-too-deep error in the PermissionedDisputeGame by updating the game to use a struct as the constructor parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the stack-too-deep error in the PermissionedDisputeGame by updating the game to use a struct as the constructor parameter.