Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: Fix test flake due to log #13145

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

There was one other spot where the batcher would log after tests exit, causing a panic.

There was one other spot where the batcher would log after tests exit, causing a panic.
@mslipper mslipper requested review from a team as code owners November 29, 2024 21:15
@mslipper mslipper requested a review from sebastianst November 29, 2024 21:15
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.78%. Comparing base (9f84a4e) to head (1bdae2c).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
op-batcher/batcher/driver.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13145      +/-   ##
===========================================
- Coverage    44.46%   42.78%   -1.68%     
===========================================
  Files          801      745      -56     
  Lines        72017    67356    -4661     
===========================================
- Hits         32021    28818    -3203     
+ Misses       37379    36110    -1269     
+ Partials      2617     2428     -189     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/batcher/driver.go 3.81% <0.00%> (-0.03%) ⬇️

... and 65 files with indirect coverage changes

@geoknee geoknee added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit 4ee839a Dec 2, 2024
45 checks passed
@geoknee geoknee deleted the bugfix/batcher-flake branch December 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants