Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix just coverage #13171

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix just coverage #13171

merged 1 commit into from
Dec 3, 2024

Conversation

AmadiMichael
Copy link
Member

@AmadiMichael AmadiMichael commented Dec 2, 2024

asserts that forge coverage compiles and runs successfully in ci if enabled

@AmadiMichael AmadiMichael requested a review from a team as a code owner December 2, 2024 17:14
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.78%. Comparing base (a486dae) to head (ec9bcaa).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13171      +/-   ##
===========================================
- Coverage    44.34%   42.78%   -1.56%     
===========================================
  Files          801      745      -56     
  Lines        72026    67361    -4665     
===========================================
- Hits         31939    28823    -3116     
+ Misses       37480    36107    -1373     
+ Partials      2607     2431     -176     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 70 files with indirect coverage changes

@AmadiMichael AmadiMichael changed the title Enable coverage run in CI Fix just coverage Dec 2, 2024
@smartcontracts smartcontracts added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit 3435fcc Dec 3, 2024
45 checks passed
@smartcontracts smartcontracts deleted the sc/ci-enable-coverage branch December 3, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants