Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Cannon libraries verison agnostic #13175

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

smartcontracts
Copy link
Contributor

Updates the Cannon libraries to be version agnostic instead of
being pinned to 0.8.15. This is OK because we do not deploy
libraries outside of contracts that have pinned contract versions.

Updates the Cannon libraries to be version agnostic instead of
being pinned to 0.8.15. This is OK because we do not deploy
libraries outside of contracts that have pinned contract versions.
@smartcontracts smartcontracts requested a review from a team as a code owner December 2, 2024 19:42
@smartcontracts smartcontracts requested a review from clabby December 2, 2024 19:42
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (35c1ffd) to head (20a8a05).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13175       +/-   ##
============================================
+ Coverage    44.38%   66.77%   +22.38%     
============================================
  Files          801       56      -745     
  Lines        72026     4665    -67361     
============================================
- Hits         31970     3115    -28855     
+ Misses       37455     1378    -36077     
+ Partials      2601      172     -2429     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (ø)
cannon-go-tests-64 56.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 745 files with indirect coverage changes

@smartcontracts smartcontracts added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit 623609a Dec 2, 2024
44 checks passed
@smartcontracts smartcontracts deleted the sc/cannon-libs-version-agnostic branch December 2, 2024 20:01
@smartcontracts smartcontracts mentioned this pull request Dec 2, 2024
31 tasks
sigma pushed a commit that referenced this pull request Dec 19, 2024
Updates the Cannon libraries to be version agnostic instead of
being pinned to 0.8.15. This is OK because we do not deploy
libraries outside of contracts that have pinned contract versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants