Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: remove versions.json #13184

Merged
merged 1 commit into from
Dec 3, 2024
Merged

maint: remove versions.json #13184

merged 1 commit into from
Dec 3, 2024

Conversation

smartcontracts
Copy link
Contributor

Removes the legacy versions.json file and replaces it with references to mise.toml.

@smartcontracts smartcontracts force-pushed the sc/remove-versions-json branch from 4d79196 to b0b5d40 Compare December 3, 2024 16:45
Removes the legacy versions.json file and replaces it with
references to mise.toml.
@smartcontracts smartcontracts force-pushed the sc/remove-versions-json branch from b0b5d40 to 6dc5366 Compare December 3, 2024 16:46
@smartcontracts smartcontracts marked this pull request as ready for review December 3, 2024 16:57
@smartcontracts smartcontracts requested review from a team as code owners December 3, 2024 16:57
@mslipper mslipper added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit e43ade1 Dec 3, 2024
41 checks passed
@mslipper mslipper deleted the sc/remove-versions-json branch December 3, 2024 18:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (3f43f03) to head (6dc5366).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13184      +/-   ##
===========================================
- Coverage    44.35%   44.20%   -0.16%     
===========================================
  Files          806      806              
  Lines        72628    72628              
===========================================
- Hits         32216    32102     -114     
- Misses       37786    37910     +124     
+ Partials      2626     2616      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

sigma pushed a commit that referenced this pull request Dec 19, 2024
Removes the legacy versions.json file and replaces it with
references to mise.toml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants