e2e/actions: enhance holocene activation action test to cover execution layer #13188
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13188 +/- ##
===========================================
- Coverage 44.25% 42.63% -1.62%
===========================================
Files 807 751 -56
Lines 72694 68029 -4665
===========================================
- Hits 32173 29007 -3166
+ Misses 37905 36580 -1325
+ Partials 2616 2442 -174
Flags with carried forward coverage won't be shown. Click here to find out more. |
sebastianst
approved these changes
Dec 4, 2024
sebastianst
deleted the
gk/holocene-activation-action-test-improvement
branch
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
…on layer (#13188) * enhance holoene activation action test to cover execution layer * apply suggestions from code review * undo changes to submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seems a prudent sanity check.
One subtlety here is that consensus layer and execution layers actually activate their "features" at different logical moments. The activation timestamp is the same, but for the former it is an l1 inclusion block timestamp and for the latter it is an l2 block timestamp.