op-e2e: Recover gracefully from log-after-exit panics #13190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of places where we log after tests exit. This PR recovers from those panics so tests can continue.
mslipper
force-pushed
the
bugfix/recover-logs
branch
from
6ad8d0e to
f5e727e
Compare
protolambda
reviewed
Dec 3, 2024
protolambda
approved these changes
Dec 3, 2024
mslipper
force-pushed
the
bugfix/recover-logs
branch
from
23196d1 to
1bd1d7c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13190 +/- ##
===========================================
- Coverage 44.24% 42.67% -1.57%
===========================================
Files 807 751 -56
Lines 72700 68042 -4658
===========================================
- Hits 32164 29036 -3128
+ Misses 37920 36563 -1357
+ Partials 2616 2443 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
* op-e2e: Recover gracefully from log-after-exit panics There are a lot of places where we log after tests exit. This PR recovers from those panics so tests can continue. * add helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of places where we log after tests exit. This PR recovers from those panics so tests can continue.