Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout fuzz tests after 10 minutes #13207

Merged
merged 2 commits into from
Dec 4, 2024
Merged

feat: timeout fuzz tests after 10 minutes #13207

merged 2 commits into from
Dec 4, 2024

Conversation

smartcontracts
Copy link
Contributor

Uses the new fuzz test timeout feature that we merged into foundry to limit individual test runs to 10 minutes. Simplifies how we need to deal with heavy fuzz testing.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (56670a7) to head (b42ee1f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13207       +/-   ##
============================================
+ Coverage    44.21%   66.77%   +22.56%     
============================================
  Files          807       56      -751     
  Lines        72707     4665    -68042     
============================================
- Hits         32146     3115    -29031     
+ Misses       37945     1378    -36567     
+ Partials      2616      172     -2444     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (ø)
cannon-go-tests-64 56.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

Uses the new fuzz test timeout feature that we merged into foundry
to limit individual test runs to 10 minutes. Simplifies how we
need to deal with heavy fuzz testing.
Improves the fuzz bounds for the OptimismPortal tests so that
they can complete 20000 runs without throwing.
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on getting this merged upstream into foundry too! LGTM :shipit: , discussed my one nit which was the 10 minute time in discord

@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 2d86cab Dec 4, 2024
44 checks passed
@mslipper mslipper deleted the sc/fuzz-timeout branch December 4, 2024 07:10
sigma pushed a commit that referenced this pull request Dec 19, 2024
* feat: timeout fuzz tests after 10 minutes

Uses the new fuzz test timeout feature that we merged into foundry
to limit individual test runs to 10 minutes. Simplifies how we
need to deal with heavy fuzz testing.

* fix: improve bounds for OptimismPortal tests

Improves the fuzz bounds for the OptimismPortal tests so that
they can complete 20000 runs without throwing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants