Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-challenger): Add TraceTypeAsteriscKona to default --trace-type option #13208

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 4, 2024

Overview

Adds TraceTypeAsteriscKona as a default option if no --trace-type flag or OP_CHALLENGER_TRACE_TYPE var is set.

@clabby clabby requested review from a team as code owners December 4, 2024 00:20
@clabby clabby self-assigned this Dec 4, 2024
@clabby clabby added the A-op-challenger Area: op-challenger label Dec 4, 2024
@clabby clabby requested review from ajsutton and removed request for geoknee and ControlCplusControlV December 4, 2024 00:20
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clabby clabby force-pushed the cl/adjust-challenger-flag-default branch from 22916dd to 831f99d Compare December 4, 2024 00:30
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.64%. Comparing base (4ce84f1) to head (831f99d).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13208      +/-   ##
===========================================
- Coverage    44.25%   42.64%   -1.61%     
===========================================
  Files          807      751      -56     
  Lines        72707    68042    -4665     
===========================================
- Hits         32177    29019    -3158     
+ Misses       37914    36576    -1338     
+ Partials      2616     2447     -169     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-challenger/flags/flags.go 6.08% <ø> (ø)

... and 66 files with indirect coverage changes

@clabby clabby added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 7457c56 Dec 4, 2024
44 checks passed
@clabby clabby deleted the cl/adjust-challenger-flag-default branch December 4, 2024 02:22
sigma pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-challenger Area: op-challenger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants