fix: workaround for foundry snapshot nuking bug #13209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for a bug? feature? in foundry that causes it to nuke whatever snapshots directory you have configured. Since this now defaults to "snapshots" it was nuking our snapshots folder.
|
Can you track this somewhere in our own repo as an issue and I can approve? |
Tracked on Foundry here: foundry-rs/foundry#9477 Tracked locally here: #13210 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13209 +/- ##
===========================================
- Coverage 44.32% 42.64% -1.68%
===========================================
Files 807 751 -56
Lines 72707 68042 -4665
===========================================
- Hits 32228 29018 -3210
+ Misses 37857 36582 -1275
+ Partials 2622 2442 -180
Flags with carried forward coverage won't be shown. Click here to find out more. |
LGTM
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
Workaround for a bug? feature? in foundry that causes it to nuke whatever snapshots directory you have configured. Since this now defaults to "snapshots" it was nuking our snapshots folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for a bug? feature? in foundry that causes it to nuke whatever snapshots directory you have configured. Since this now defaults to "snapshots" it was nuking our snapshots folder.