op-e2e: Add timeouts to sequencer failover tests #13224
Merged
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can sometimes never return, which leads to tests timing out in CI. This PR adds timeouts so we can get feedback faster.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13224 +/- ##
===========================================
- Coverage 44.33% 42.63% -1.71%
===========================================
Files 807 751 -56
Lines 72707 68042 -4665
===========================================
- Hits 32237 29010 -3227
+ Misses 37844 36586 -1258
+ Partials 2626 2446 -180
Flags with carried forward coverage won't be shown. Click here to find out more. |
zhwrd
approved these changes
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
* op-e2e: Add timeouts to sequencer failover tests These can sometimes never return, which leads to tests timing out in CI. This PR adds timeouts so we can get feedback faster. * avoid capturing parent t in subtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can sometimes never return, which leads to tests timing out in CI. This PR adds timeouts so we can get feedback faster.