Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: update unused imports check to use new pattern #13227

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

smartcontracts
Copy link
Contributor

Updates the unused imports contract check to use the new framework that we recently merged.

@smartcontracts smartcontracts requested a review from a team as a code owner December 4, 2024 18:34
Updates the unused imports contract check to use the new
framework that we recently merged.
@smartcontracts smartcontracts force-pushed the sc/maint-unused-imports-fixup branch from 991fec5 to 928c06a Compare December 4, 2024 18:34
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 42.73%. Comparing base (c3e535c) to head (928c06a).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...acts-bedrock/scripts/checks/unused-imports/main.go 29.16% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13227      +/-   ##
===========================================
- Coverage    44.35%   42.73%   -1.63%     
===========================================
  Files          807      751      -56     
  Lines        72707    67999    -4708     
===========================================
- Hits         32247    29056    -3191     
+ Misses       37831    36501    -1330     
+ Partials      2629     2442     -187     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...acts-bedrock/scripts/checks/unused-imports/main.go 42.59% <29.16%> (+42.59%) ⬆️

... and 65 files with indirect coverage changes

Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 21827a2 Dec 4, 2024
44 checks passed
@smartcontracts smartcontracts deleted the sc/maint-unused-imports-fixup branch December 4, 2024 19:41
sigma pushed a commit that referenced this pull request Dec 19, 2024
Updates the unused imports contract check to use the new
framework that we recently merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants