-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-supervisor,op-node: introduce follow/managed interop mode #13285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some todos, but thank you for putting this together, it's looking good
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13285 +/- ##
===========================================
- Coverage 47.39% 42.82% -4.57%
===========================================
Files 928 767 -161
Lines 78145 68662 -9483
Branches 849 0 -849
===========================================
- Hits 37036 29406 -7630
+ Misses 38392 36756 -1636
+ Partials 2717 2500 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
693ac81
to
76bb186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Had reviewed this last week synchronously
- I am building new code off of this branch so I can confirm it works and I am motivated to merge it
- I did not look too closely at the Temporary server, as that exists almost entirely to provide a smooth experience in testing as we build out features. So long as it's functional (which by test results it is) I am fine with it.
LGTM, thanks!
* op-supervisor,op-node: introduce follow/managed interop mode v2 * interop: test workaround, serve supervisor while using old deriver * interop: fix API setup/usage, fix action test setup * op-node: fix interop server endpoint getter * interop: minor fixes, update TODO references
Description
This PR changes the op-node and op-supervisor to support two ways of interacting with each other:
Changes:
addL2RPC
now has a JWT secret arg, to connect to an authenticated RPCEthClient
provides blockref fetching methods now, to not have to rely on theL1BlockRef
methods in a L2 context.L1Client
uses these blockref methodsMockEthClient
supports mocking of these methodsTests
All existing op-e2e tests pass, using the new RPC and configuration functionality. Some workarounds were required, since the full standard/managed mode has not been implemented yet.
Additional context
Metadata
Fix #13182