Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-deployer: Bootstrap superchain command #13294

Merged
merged 2 commits into from
Dec 6, 2024
Merged

op-deployer: Bootstrap superchain command #13294

merged 2 commits into from
Dec 6, 2024

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 6, 2024

Fixes #13265.

@mslipper mslipper requested a review from a team as a code owner December 6, 2024 19:14
@mslipper mslipper requested a review from protolambda December 6, 2024 19:14
@mslipper mslipper force-pushed the feat/bootstrap-superchain branch from 44deae0 to 0c09dc8 Compare December 6, 2024 19:15
@mslipper mslipper requested a review from blmalone December 6, 2024 19:17
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.88591% with 100 lines in your changes missing coverage. Please review.

Project coverage is 42.30%. Comparing base (f21f95e) to head (e08f7d4).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/superchain.go 32.88% 82 Missing and 18 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #13294      +/-   ##
===========================================
- Coverage    46.92%   42.30%   -4.62%     
===========================================
  Files          926      758     -168     
  Lines        77805    68194    -9611     
  Branches       849        0     -849     
===========================================
- Hits         36511    28851    -7660     
+ Misses       38641    36944    -1697     
+ Partials      2653     2399     -254
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/bootstrap/superchain.go 32.88% <32.88%> (ø)

... and 180 files with indirect coverage changes

blmalone
blmalone approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mslipper mslipper added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 63140ba Dec 6, 2024
42 checks passed
@mslipper mslipper deleted the feat/bootstrap-superchain branch December 6, 2024 19:48
sigma pushed a commit that referenced this pull request Dec 19, 2024
@mslipper @sigma
op-deployer: Bootstrap superchain command (#13294)
00f0b9f 
* op-deployer: Bootstrap superchain command

Fixes #13265.

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmalone blmalone blmalone approved these changes

@protolambda protolambda Awaiting requested review from protolambda protolambda is a code owner automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command op-deployer bootstrap superchain
2 participants
@mslipper @blmalone