Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txmgr: Fix gas estimation call #8578

Merged
merged 1 commit into from
Dec 12, 2023
Merged

txmgr: Fix gas estimation call #8578

merged 1 commit into from
Dec 12, 2023

Conversation

sebastianst
Copy link
Member

Description

  • The tip cap and fee cap fields have been mixed up
  • Also improve logging

Tests

Two fields in the backend call were mixed up. I don't see value now in adding a test that validates that the fields are set properly.

Additional context

This caused a 20 min safe head stall on Goerli earlier today.

@sebastianst sebastianst requested a review from a team as a code owner December 12, 2023 10:45
Copy link
Contributor

coderabbitai bot commented Dec 12, 2023

Walkthrough

Walkthrough

The recent update to the transaction manager service in the codebase primarily refines variable declarations and enhances logging capabilities. Variables related to gas price calculation are now declared in a grouped syntax for better readability. Additionally, the increaseGasPrice method within the SimpleTxManager has been updated to provide more detailed logging, specifically including gasFeeCap and gasTipCap in its output, which offers more insight into gas price adjustments and estimations.

Changes

File Summary
op-service/.../txmgr.go Updated variable declarations to a grouped syntax; enhanced logging in increaseGasPrice method to include gasFeeCap and gasTipCap.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@sebastianst sebastianst force-pushed the seb/fix-txmgr-gas-est branch from 47a7e61 to 28fb816 Compare December 12, 2023 10:51
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of log messages to fix up I think.

op-service/txmgr/txmgr.go Show resolved Hide resolved
op-service/txmgr/txmgr.go Show resolved Hide resolved
- The tip cap and fee cap fields have been mixed up
- Also improve logging
@sebastianst sebastianst force-pushed the seb/fix-txmgr-gas-est branch from 28fb816 to e1e639e Compare December 12, 2023 11:48
@sebastianst sebastianst added this pull request to the merge queue Dec 12, 2023
Merged via the queue into develop with commit d346f07 Dec 12, 2023
59 checks passed
@sebastianst sebastianst deleted the seb/fix-txmgr-gas-est branch December 12, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants