-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txmgr: Fix gas estimation call #8578
Conversation
WalkthroughWalkthroughThe recent update to the transaction manager service in the codebase primarily refines variable declarations and enhances logging capabilities. Variables related to gas price calculation are now declared in a grouped syntax for better readability. Additionally, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
47a7e61
to
28fb816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of log messages to fix up I think.
- The tip cap and fee cap fields have been mixed up - Also improve logging
28fb816
to
e1e639e
Compare
Description
Tests
Two fields in the backend call were mixed up. I don't see value now in adding a test that validates that the fields are set properly.
Additional context
This caused a 20 min safe head stall on Goerli earlier today.