Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/naming #486

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix/naming #486

merged 2 commits into from
Jan 28, 2025

Conversation

ElliotFriedman
Copy link
Contributor

Change all naming from Proposal to Task.

Tests

This is only a naming convention change, no tests needed.

Metadata

Should close #475

@ElliotFriedman ElliotFriedman marked this pull request as ready for review January 28, 2025 07:00
@ElliotFriedman ElliotFriedman requested review from a team as code owners January 28, 2025 07:00
ControlCplusControlV
ControlCplusControlV reviewed Jan 28, 2025
View reviewed changes
Copy link

@ControlCplusControlV ControlCplusControlV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blmalone blmalone added this pull request to the merge queue Jan 28, 2025
Merged via the queue into ethereum-optimism:main with commit 3e82c63 Jan 28, 2025
15 checks passed
@ElliotFriedman ElliotFriedman deleted the fix/naming branch January 28, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ControlCplusControlV ControlCplusControlV ControlCplusControlV left review comments

@blmalone blmalone blmalone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Proposal to Task
3 participants
@ElliotFriedman @blmalone @ControlCplusControlV