op-sepolia: Add task to switch back to singlethreaded cannon. #544
+283
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Feb 5, 2025
mbaxter
reviewed
Feb 6, 2025
ajsutton
force-pushed
the
aj/revert-cannon-mt
branch
from
ead701d to
ce7ae41
Compare
mbaxter
previously approved these changes
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
Ethnical
reviewed
Feb 7, 2025
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.
ajsutton
force-pushed
the
aj/revert-cannon-mt
branch
from
3d57983 to
6a8b1d6
Compare
|
The simulation match the verification files as expected for both SC an FND. |
Ethnical
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
LGTM!
I would like to know how we can ensure that the deployment of the both DG is correct:
I have opened a slack discussion + discord and we should merge this when we resolve this off to make sure this is desired.
For the CI errors this is related to rate limiting, I have opened an issue here #569 to fix it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add task to switch back to singlethreaded cannon.
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.