Update HTTP->HTTPS when both URLs work #1714
Conversation
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
| @@ -28,16 +28,16 @@ Moving to PoS has been on the roadmap since day 0 for ethereum, along with a red | |||
|
|
|||
| #### Asics and advantadges of PoW | |||
|
|
|||
| [EIP 960](http://eips.ethereum.org/EIPS/eip-969) proposes a change in algorithm to avoid mining being dominated by ASICS. Counter arguments by Phil Daian argue among others than [resisting economies of scale is futile and there might be specific security advantadges to specialized hardware](https://pdaian.com/blog/anti-asic-forks-considered-harmful/). One of the main arguments for PoW mining, even when it doesn't provide security, it is useful as a fair distribution mechanism, that **PoW allows any person with a computer, internet access and electricity to obtain currency without having to deal with government imposed currency controls**. | |||
| [EIP 960](https://eips.ethereum.org/EIPS/eip-969) proposes a change in algorithm to avoid mining being dominated by ASICS. Counter arguments by Phil Daian argue among others than [resisting economies of scale is futile and there might be specific security advantadges to specialized hardware](https://pdaian.com/blog/anti-asic-forks-considered-harmful/). One of the main arguments for PoW mining, even when it doesn't provide security, it is useful as a fair distribution mechanism, that **PoW allows any person with a computer, internet access and electricity to obtain currency without having to deal with government imposed currency controls**. | |||
There was a problem hiding this comment.
| [EIP 960](https://eips.ethereum.org/EIPS/eip-969) proposes a change in algorithm to avoid mining being dominated by ASICS. Counter arguments by Phil Daian argue among others than [resisting economies of scale is futile and there might be specific security advantadges to specialized hardware](https://pdaian.com/blog/anti-asic-forks-considered-harmful/). One of the main arguments for PoW mining, even when it doesn't provide security, it is useful as a fair distribution mechanism, that **PoW allows any person with a computer, internet access and electricity to obtain currency without having to deal with government imposed currency controls**. | |
| [EIP 960](https://eips.ethereum.org/EIPS/eip-969) proposes a change in algorithm to avoid mining being dominated by ASICS. Counter arguments by Phil Daian argue among others that [resisting economies of scale is futile and there might be specific security advantadges to specialized hardware](https://pdaian.com/blog/anti-asic-forks-considered-harmful/). One of the main arguments for PoW mining, even when it doesn't provide security, it is useful as a fair distribution mechanism, that **PoW allows any person with a computer, internet access and electricity to obtain currency without having to deal with government imposed currency controls**. |
There was a problem hiding this comment.
Not going to look at the rest of this.
I don't have official approval rights on this repo, but the changes to 1066 & 1444 look good 👍 |
perhaps it would make sense to modify this bot so a thumbs up also counts as approval if the person does not have the permission to approve |
|
There's no "approval rights"; anyone can approve a PR. Just go to the code tab, click "Review Changes", "Approve", and "Submit". |
|
Indeed. Welp, that's embarrassing! 😅🤣 |
|
I agree with this PR but currently has conflicts. @fulldecent |
|
@nicksavers thank you, de-conflicted |
|
I verified that all the updated links are working. Thanks for the work @fulldecent |
|
Thanks for the review! |
|
This updates each HTTP links to HTTPS if and only if the updated URL is accessible.
We should update our links to HTTPS because this promotes privacy.
This is a pure-play commit for the above feature and it does not touch anything else.
One reason is that there are so many HTTP URLs is because for a brief time the eips.ethereum.org website was available on HTTP without redirect. Therefore, after this change, I expect in the future there will be much less need for changes like the instant PR.