-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate file #2452
Remove duplicate file #2452
Conversation
@Arachnid approved above, requesting review please |
While these two files were identical at the time they were merged, now they have diverged a tiny bit. To me it seems that EIP-1046 is the more "maintained" version, and would agree with removing it. However, this opens the question and precedent: should "invalid" or mistakenly merged EIPs be ever removed or only marked Abandoned/Withdrawn/Superseded? More feedback from @Souptacular @MicahZoltu @lightclient would be welcome. |
I like the idea of editors having some "editorial power" in matters like this. I would generally agree that once an EIP is published, it should become a permanent fixture. But I also understand that the editors are trying to curate and publish a cohesive set of EIPs, and IMO deleting a duplicate (mistake) EIP is within the bounds of an editor's power. Given that this EIP is still a draft, and based on it's limited reach (based on a brief few internet searches just now), I don't see an issue with merging this. |
I'm a fan of deleting abandoned EIPs rather than just flagging them as abandoned, but I believe I'm alone with this stance. In this case, I favor deletion but would accept abandoned. |
Hah, I just noticed these are using reddit as a discussion url, see #2967. |
@MicahZoltu @lightclient only realised now that the authors actually approved this. If they have I'm on board getting rid of it! It would be a different conversation should the authors not respond. |
With the author's approval, I'm good on deleting this if other editors are (which it sounds like they are). |
This is a duplicate of https://eips.ethereum.org/EIPS/eip-1046
Ping for approval: Tommy Nicholas (@tomasienrbc), Matt Russo (@mateosu), John Zettler (@JohnZettler), Matt Condon (@shrugs)
See #1046 and #1047.