-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC-1363: Move to Last Call #2617
ERC-1363: Move to Last Call #2617
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
It is not possible to move from draft to final in a single step, please refer to EIP-1. |
Updated to Last Call. It was Last Call first but automerger fails. So I moved to final. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last Call must have a review-period-end
of at least 2 weeks in the future.
Co-authored-by: Micah Zoltu <[email protected]>
|
I would also recommend changing:
to
|
I recommend using the RFC 2119 style for |
Recommend changing:
to
|
Recommend changing the abstract to be a bit more descriptive, maybe mentioning the highlights of the new functions. I generally recommend the abstract contain a human-readable and terse version of the specification. Something like, "Adds a Basically, state the core protocol in human readable words, but don't cover all of the edge cases and little details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Security Considerations section is a hard requirement. The rest are feedback that I encourage applying, but aren't strictly required to move to Last Call.
I know I said that the other changes were optional, but on doing a final review I think this change is necessary afterall because the current wording doesn't align with the rest of the document:
to
"other than" implies that someone implementing this standard MUST NOT implement ERC-20 and ERC-165, which I don't think was the intent. Along with that change, please also set the review period end to 2 weeks from the date of that change as I hope this is the last change before Last Call. 😄 |
Defines a token interface for ERC-20 tokens that supports executing recipient code on `transfer` or spender code on `approve`.
Defines a token interface for ERC-20 tokens that supports executing recipient code on `transfer` or spender code on `approve`.
Moves ERC-1363 to Final.