Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2255: Add external images to assets folder #2649

Merged
merged 4 commits into from
Sep 6, 2020

Conversation

rekmarks
Copy link
Contributor

@rekmarks rekmarks commented May 15, 2020

Add externally linked images to assets/eip-2255 per: #2648 (comment)

Link to file: https://github.com/rekmarks/EIPs/blob/2255-fix-assets/EIPS/eip-2255.md

@rekmarks rekmarks marked this pull request as draft May 15, 2020 23:11
@rekmarks rekmarks marked this pull request as ready for review May 15, 2020 23:13
@rekmarks rekmarks marked this pull request as draft May 15, 2020 23:13
@rekmarks rekmarks marked this pull request as ready for review May 15, 2020 23:14
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-2255/facebook_permissions.png is not an EIP
  • File assets/eip-2255/log_in_with_apple.jpeg is not an EIP
  • File assets/eip-2255/permissions_adventure.gif is not an EIP

@rekmarks
Copy link
Contributor Author

@axic maintainer approval/merge required

@MicahZoltu MicahZoltu merged commit 4a8fb2a into ethereum:master Sep 6, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants