Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1193: Add "Security Considerations" #2694

Merged
merged 3 commits into from
Jun 4, 2020
Merged

1193: Add "Security Considerations" #2694

merged 3 commits into from
Jun 4, 2020

Conversation

rekmarks
Copy link
Contributor

@rekmarks rekmarks commented Jun 3, 2020 •
edited
Loading

File: https://github.com/rekmarks/EIPs/blob/1193-security-considerations/EIPS/eip-1193.md

Adds Security Considerations to EIP-1193.

Also includes some minor stylistic fixes/corrections.

@rekmarks rekmarks mentioned this pull request Jun 3, 2020
Closed
danfinlay
danfinlay approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I added two possible changes as suggestions.

EIPS/eip-1193.md Outdated Show resolved Hide resolved
EIPS/eip-1193.md Outdated Show resolved Hide resolved
ryanio
ryanio approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rekmarks looks great, thanks for putting this together. dan's suggestions look good as well. i'll give an approval for now but let me know if it would need a re-approval after update.

@rekmarks @danfinlay
Update EIPS/eip-1193.md
9c9ffe2 
Co-authored-by: Dan Finlay <[email protected]>
@rekmarks rekmarks marked this pull request as ready for review June 4, 2020 05:23
@eip-automerger eip-automerger merged commit 6e68ede into ethereum:master Jun 4, 2020
@rekmarks rekmarks deleted the 1193-security-considerations branch June 4, 2020 05:34
pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
@rekmarks @pizzarob
Automatically merged updates to draft EIP(s) 1193 (ethereum#2694)
5600e53 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@rekmarks @tkstanczak
Automatically merged updates to draft EIP(s) 1193 (ethereum#2694)
65a0870 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@rekmarks @Arachnid
Automatically merged updates to draft EIP(s) 1193 (ethereum#2694)
8897434 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

@ryanio ryanio ryanio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @ryanio @danfinlay @eip-automerger