1193: Final edits in response to feedback #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ryanio
reviewed
Jun 4, 2020
EIPS/eip-1193.md
Outdated
| @@ -15,12 +15,10 @@ requires: 155, 695 | |||
|
|
|||
| This EIP formalizes a JavaScript Ethereum Provider API for consistency across clients and applications. | |||
|
|
|||
| The Provider's interface is designed to be minimal, preferring that features are introduced in the API layer (see e.g. [`eth_requestAccounts`](https://eips.ethereum.org/EIPS/eip-1102)), and agnostic of transport and RPC protocols. | |||
| The Provider's interface is designed to be minimal and agnostic of transport and RPC protocols. | |||
There was a problem hiding this comment.
My intention with these words were for implementers to keep away from extending and adding their own methods and properties to the provider object as it just causes confusion and fragmentation.
There was a problem hiding this comment.
The new text will be as follows, and I do think that it conveys that new functionality can be added via new RPC methods.
The Provider's interface is designed to be minimal, event-driven, and agnostic of transport and RPC protocols.
There was a problem hiding this comment.
Added back updated language reflecting goals in ffe92ce
ryanio
reviewed
Jun 4, 2020
rekmarks
force-pushed
the
1193-final-draft
branch
from
ffe92ce to
ff39c4a
Compare
pizzarob
pushed a commit
to pizzarob/EIPs
that referenced
this pull request
Jun 12, 2020
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to file: https://github.com/rekmarks/EIPs/blob/1193-final-draft/EIPS/eip-1193.md
EventsspecificationEventEmitterfrom normative to non-normativeEventEmitterAPI, while stable is growing over timemessageevent "Subscription" subsection in API documentation