Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1193: Reorganize and add missing sections #2702

Merged
merged 5 commits into from
Jun 5, 2020
Merged

1193: Reorganize and add missing sections #2702

merged 5 commits into from
Jun 5, 2020

Conversation

rekmarks
Copy link
Contributor

@rekmarks rekmarks commented Jun 5, 2020

File: https://github.com/rekmarks/EIPs/blob/1193-sections/EIPS/eip-1193.md

  • Reorganize and add missing sections per EIP-1
  • Normative change: don't require Providers to implement the emit method
    • For the purposes of the spec, it's an implementation detail
  • Various minor cleanup/fixups

ryanio
ryanio approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for formatting to the sections and you really incorporated the feedback to simplify.

@rekmarks rekmarks marked this pull request as ready for review June 5, 2020 03:33
@eip-automerger eip-automerger merged commit c90b98e into ethereum:master Jun 5, 2020
@gcolvin gcolvin mentioned this pull request Jun 9, 2020
Merged
pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
@rekmarks @pizzarob
Automatically merged updates to draft EIP(s) 1193 (ethereum#2702)
534a1db 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@rekmarks @tkstanczak
Automatically merged updates to draft EIP(s) 1193 (ethereum#2702)
685eb66 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@rekmarks @Arachnid
Automatically merged updates to draft EIP(s) 1193 (ethereum#2702)
9f9820d 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @ryanio @eip-automerger