Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eip2333 clarifications #2743

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Conversation

CarlBeek
Copy link
Contributor

Clarifications:

  • It was unclear whether the indexing was inclusive or exclusive of the bounds
  • That BIP39 should be used to derive seeds

Changes:

  • derive_master_SK, and HKDF_mod_r now require a minimum input length of 32 bytes to line up with the definition in the BLS specs

@eip-automerger eip-automerger merged commit 8fa2aa6 into ethereum:master Jun 19, 2020
mratsim added a commit to status-im/nim-blscurve that referenced this pull request Jul 16, 2020
)

* Drop hash-to-curve v5 support

* Update HKDF_mod_r for EIP2333 and BLS sig scheme draft 2 (ethereum/EIPs#2748, ethereum/EIPs#2744, ethereum/EIPs#2743, https://tools.ietf.org/rfcdiff?url1=https://tools.ietf.org/id/draft-irtf-cfrg-bls-signature-00.txt&url2=https://tools.ietf.org/id/draft-irtf-cfrg-bls-signature-02.txt)

* Update EIP2333 key derivation tests

* Avoid heap allocation for appends prior to all HKDF calls
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants