-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove external links in non-conforming EIPs #2753
Remove external links in non-conforming EIPs #2753
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Hi @Nitro888, @yoav-tabookey, and @MadeofTin please take a moment to review my changes to your EIP. I've simply downloaded the images linked in the EIP document and placed them in the in the |
121713f
to
f9bfd43
Compare
I'm not sure why this didn't auto-merge when @yoav-tabookey approved. Going to manually merge for now and we can figure out the bot problem later. |
Because two more EIPs were affected and those people did not approve and it also changed files outside of the EIPs, as evidenced by the bots message: #2753 (comment) |
Ah wow, I must have been totally out of it when I looked at this PR. 😳 Will try to do better at reading comprehension in the future. |
Per ethereum#2648, I'm removing links to external images and instead placing them in the proper /assets directory.
Per ethereum#2648, I'm removing links to external images and instead placing them in the proper /assets directory.
Per #2648, I'm removing links to external images and instead placing them in the proper
/assets
directory.