Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external links in non-conforming EIPs #2753

Merged
merged 4 commits into from
Jul 17, 2020

Conversation

lightclient
Copy link
Member

Per #2648, I'm removing links to external images and instead placing them in the proper /assets directory.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@eip-automerger
Copy link

eip-automerger commented Jun 26, 2020

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-1175/wallet.png is not an EIP
  • File assets/eip-1175/workflow.png is not an EIP
  • File assets/eip-1438/avatar.png is not an EIP
  • File assets/eip-1438/intro.png is not an EIP
  • File assets/eip-1438/wallet.png is not an EIP
  • File assets/eip-1613/sequence.png is not an EIP
  • File assets/eip-2025/block_rewards_distribution.png is not an EIP
  • File assets/eip-2025/loan_state.png is not an EIP
  • EIP 1175 requires approval from one of (@Nitro888)
  • EIP 1438 requires approval from one of (@Nitro888)
  • EIP 2025 requires approval from one of (@MadeofTin)

@lightclient
Copy link
Member Author

lightclient commented Jun 26, 2020

Hi @Nitro888, @yoav-tabookey, and @MadeofTin please take a moment to review my changes to your EIP. I've simply downloaded the images linked in the EIP document and placed them in the in the /assets directory.

@lightclient lightclient force-pushed the remove-external-links branch from 121713f to f9bfd43 Compare June 26, 2020 20:18
@MicahZoltu
Copy link
Contributor

I'm not sure why this didn't auto-merge when @yoav-tabookey approved. Going to manually merge for now and we can figure out the bot problem later.

@MicahZoltu MicahZoltu merged commit 65e0950 into ethereum:master Jul 17, 2020
@axic
Copy link
Member

axic commented Jul 23, 2020

I'm not sure why this didn't auto-merge when @yoav-tabookey approved.

Because two more EIPs were affected and those people did not approve and it also changed files outside of the EIPs, as evidenced by the bots message: #2753 (comment)

@MicahZoltu
Copy link
Contributor

Ah wow, I must have been totally out of it when I looked at this PR. 😳 Will try to do better at reading comprehension in the future.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Per ethereum#2648, I'm removing links to external images and instead placing them in the proper /assets directory.
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Per ethereum#2648, I'm removing links to external images and instead placing them in the proper /assets directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants