-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON-LD for EIPS #2796
Add JSON-LD for EIPS #2796
Conversation
_layouts/eip.html
Outdated
"@context": "http://schema.org", | ||
"@type": "Article", | ||
"author": "{% include authorlist.html authors=page.author %}", | ||
"name": "EIP-{{ page.eip | xml_escape }}: {{ page.title | xml_escape }}{% if page.status == "Draft" or page.status = "Last Call" %} [DRAFT]{% endif %}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From CI:
Liquid Warning: Liquid syntax error (line 50): Unexpected character = in "page.status == "Draft" or page.status = "Last Call"" in /_layouts/eip.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected at b929e3d
Same comment as in #2738. You should get this added to the next EIPIP meeting agenda since it is a meta change. |
EIPIP is not authoritative and does not have decision makers. Therefore it is ineffectual and that is why I left. This current matter affects nobody, it is merely a HTML coding update, I believe it can be accepted with input only by a single person with commit access rather than requiring votes, socializing or other consensus measures. |
Took another gander at this one and think it is fine. |
Cool, thank you |
Related: #2811 |
@@ -42,3 +42,22 @@ <h1 class="page-heading"> | |||
{{ content }} | |||
|
|||
</div> | |||
{% comment %} | |||
Article schema specification: | |||
https://schema.org/Article |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why was my comment about the schema ignored in the old PR: #2738 (comment)
I suggested TechArticle
with more fields.
See schema.org
for the distinction:
TechArticle
Thing > CreativeWork > Article > TechArticle
A technical article - Example: How-to (task) topics, step-by-step, procedural troubleshooting, specifications, etc.
vs.
Article
Thing > CreativeWork > Article
An article, such as a news article or piece of investigative report. Newspapers and magazines have articles of many different types and this is intended to cover them all.See also blog post.
I do not think EIPs should be considered as blog posts or news articles.
Also as mentioned in #2738 (comment) this PR added the JSON+LD as a duplicate entry, given it already exists in |
Google's testing tool displays errors: Can we be a bit more prudent about merging PRs? |
@axic The JSON-LD in the head is NOT a conflict against this new JSON. The former regards the website a whole ( |
@axic The Google tool shows errors. And that is fine. We do not currently require images for each EIP and I do not expect that to change soon. Either way, I believe life is better with this PR merged and if images will be added then that can be considered separately. SEO was an overarching concern for the EIPs project and this PR is aligned with that goal. |
I contend that this PR was an improvement, thus worth merging. It added JSON-LD content that improved SEO. I believe the errors/warnings are just "you can do better" things, and not all of them are possible for us to address (like the That being said, it would be nice to get the rest added like |
* Add JSON-LD for EIPS * Update eip.html
* Add JSON-LD for EIPS * Update eip.html
Extracted from PR at #2738