Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eip-1538.md #2805

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Update eip-1538.md #2805

merged 2 commits into from
Jul 20, 2020

Conversation

mudgen
Copy link
Contributor

@mudgen mudgen commented Jul 19, 2020

Fixed link to EIP-2535.

@mudgen
Update eip-1538.md
f855fd9 
Fixed link to EIP-2535.
MicahZoltu
MicahZoltu suggested changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use relative links when pointing at other EIPs so it works both in GitHub and the EIPs site.

EIPS/eip-1538.md Outdated Show resolved Hide resolved
@mudgen
Copy link
Contributor Author

mudgen commented Jul 20, 2020

Good idea, thanks @MicahZoltu. It is done.

@MicahZoltu MicahZoltu merged commit 65bf86e into ethereum:master Jul 20, 2020
lightclient
lightclient reviewed Jul 27, 2020
View reviewed changes
EIPS/eip-1538.md
@@ -9,7 +9,7 @@ category: ERC
created: 2018-10-31
---

Replaced by [EIP-2535 Diamond Standard](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2535.md).
Replaced by [EIP-2535 Diamond Standard](./eip-2535.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the body of the EIP rather than as the preamble field superceded-by?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because EIP-2535 isn't final yet. But I would be happy to make this change if it is okay.

Copy link
Member

@lightclient lightclient Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I suppose this is okay for now then. Looking over EIP-1 now - I don't believe it covers this sort of situation very well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is talk of removing the superceded by concept, since deciding what supercedes what is a governance nightmare. Take for example the 15 different token standards that all claim to supersede ERC-20.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of removing it.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@mudgen @tkstanczak
Update eip-1538.md (ethereum#2805)
696f00f 
* Update eip-1538.md

Fixed link to EIP-2535.

* Update eip-1538.md
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@mudgen @Arachnid
Update eip-1538.md (ethereum#2805)
495ff9b 
* Update eip-1538.md

Fixed link to EIP-2535.

* Update eip-1538.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient left review comments

@MicahZoltu MicahZoltu MicahZoltu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mudgen @MicahZoltu @lightclient