Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced/Corrected Motivation Section #2883

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

jaerith
Copy link
Contributor

@jaerith jaerith commented Aug 16, 2020

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

jaerith added 3 commits July 28, 2020 19:44
Updated URL for EIP-2535
Added clarification and fixed misspellings.
@MicahZoltu MicahZoltu closed this Aug 18, 2020
@MicahZoltu MicahZoltu reopened this Aug 18, 2020
@MicahZoltu MicahZoltu closed this Aug 20, 2020
@MicahZoltu MicahZoltu reopened this Aug 20, 2020
@eip-automerger eip-automerger merged commit 51d190c into ethereum:master Aug 20, 2020
@axic
Copy link
Member

axic commented Aug 20, 2020

author: Aaron Kendall (@jaerith), Juan Blanco <@juanfranblanco>

I was wondering how did this PR pass the CI with this broken header (eipv would complain). Well, it passed because it was not rebased/merge-to-master and hence it still ran the old CI config.

Is eipv not detecting these?

@jaerith
Copy link
Contributor Author

jaerith commented Aug 20, 2020

Sorry, guys. Did I cause any trouble with my PR? Just to be safe, I suppose that I'll delete my current fork of EIPS and just create a new one.

@MicahZoltu
Copy link
Contributor

@jaerith It has been resolved in #2887, the automated tool should have caught the mistake and prevented us from merging.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants