Update html title to be EIP-N #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
approved these changes
Aug 29, 2020
axic
reviewed
Aug 29, 2020
_includes/head.html
Outdated
| @@ -3,7 +3,7 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
| {% if page.layout == "eip" %} | |||
| <title>EIP {{ page.eip }}: {{ page.title | escape }}</title> | |||
| <title>EIP-{{ page.eip }}: {{ page.title | escape }}</title> | |||
| <meta property="og:title" content="EIP {{ page.eip }}: {{ page.title | escape }}" /> | |||
There was a problem hiding this comment.
Suggested change
| <meta property="og:title" content="EIP {{ page.eip }}: {{ page.title | escape }}" /> | |
| <meta property="og:title" content="EIP-{{ page.eip }}: {{ page.title | escape }}" /> |
There was a problem hiding this comment.
And more instances of this to be found in the metadata below.
There was a problem hiding this comment.
Should be updated now, thanks for pointing those out.
MicahZoltu
approved these changes
Aug 29, 2020
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
* update html title to be EIP-N * update unfurlers to be EIP-N
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
* update html title to be EIP-N * update unfurlers to be EIP-N
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title before:
EIP 1: EIP Purpose and GuidelinesTitle after:
EIP-1: EIP Purpose and GuidelinesReflects the style guide in EIP-1: