Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2976: eth/##: Typed Transactions over Gossip #2976

Merged
merged 1 commit into from
Sep 13, 2020
Merged

2976: eth/##: Typed Transactions over Gossip #2976

merged 1 commit into from
Sep 13, 2020

Conversation

MicahZoltu
Copy link
Contributor

Adds support for transmission of typed transactions over devp2p.

@MicahZoltu MicahZoltu changed the title ####: eth/##: Typed Transactions over Gossip 2976: eth/##: Typed Transactions over Gossip Sep 13, 2020
Adds support for transmission of typed transactions over devp2p.
@MicahZoltu
Copy link
Contributor Author

Going to merge this as it has received a review from an editor (me), but since it is my own PR I requested a review from @axic to get a second set of eyes. Would also love to get eyes on this by someone familiar with the networking protocol like @fjl

@@ -0,0 +1,90 @@
---
eip: 2976
title: eth/##: Typed Transactions over Gossip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to be wrapped with double quotes to render properly on the eips site. This is because the front matter parser thinks "eth/##:" is a key like "title:". This is on the backlog to validate with eipv.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I copied the name from the other networking EIPs, looking again it does appear they have quotes.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Adds support for transmission of typed transactions over devp2p.
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Adds support for transmission of typed transactions over devp2p.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants