Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create eip-5018 #5018

Merged
merged 18 commits into from
Jun 4, 2022
Merged

Create eip-5018 #5018

merged 18 commits into from
Jun 4, 2022

Conversation

qizhou
Copy link
Contributor

@qizhou qizhou commented Apr 18, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 18, 2022

All tests passed; auto-merging...

(pass) eip-5018.md

classification
updateEIP
  • passed!

@qizhou qizhou changed the title Create eip-dir Create eip-5018 Apr 20, 2022
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Show resolved Hide resolved
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Show resolved Hide resolved
qizhou and others added 5 commits May 6, 2022 21:35
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
- The purpose is to lower the cost of comparing local files with on-chain files without downloading the whole files/chunks.
EIPS/eip-5018.md Outdated Show resolved Hide resolved
Co-authored-by: Pandapip1 <[email protected]>
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking decent. Should be go to merge after these last comments.

EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Show resolved Hide resolved
qizhou and others added 3 commits May 20, 2022 21:08
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Add Subsection "Interactions Between Unchunked Functions and Chunk Functions"
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Outdated Show resolved Hide resolved
EIPS/eip-5018.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to go in as a draft. Probably needs a little more polish, but that can come later.

@MicahZoltu MicahZoltu closed this Jun 4, 2022
@MicahZoltu MicahZoltu reopened this Jun 4, 2022
@eth-bot eth-bot enabled auto-merge (squash) June 4, 2022 05:35
@eth-bot eth-bot merged commit edad44e into ethereum:master Jun 4, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Create eip-TBD.md

* Create EIP-dir

* Update and rename eip-TBD.md to eip-5018.md

* Update eip-5018.md

* Update eip-5018.md

* Update eip-5018.md

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Add getChunkHash()

- The purpose is to lower the cost of comparing local files with on-chain files without downloading the whole files/chunks.

* Update EIPS/eip-5018.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>

* Update eip-5018.md

Add Subsection "Interactions Between Unchunked Functions and Chunk Functions"

* Update eip-5018.md

* Update EIPS/eip-5018.md

Co-authored-by: lightclient <[email protected]>

* Update eip-5018.md

Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: lightclient <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants