Add EIP-5131: ENS Subdomain Authentication #5131

wwhchung · 2022-06-03T03:55:24Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-06-03T03:56:14Z

All tests passed; auto-merging...

(pass) eip-5131.md

classification
`updateEIP`

passed!

Pandapip1

I don't have the time right now to look at the content (I will later), but here are a few changes that need to be made.

EIPS/eip-603.md

wwhchung · 2022-06-03T13:17:52Z

Thanks. I have made the suggested edits.

Pandapip1 · 2022-06-03T13:18:39Z

FYI - I've left a comment on your discussion thread.

wwhchung · 2022-06-03T13:28:33Z

Saw that and responded, thanks! Look forward to continuing the discussion there!

EIPS/eip-5131.md

Pandapip1

I've got a few more suggestions (primarily changing read only to reversible

EIPS/eip-5131.md

wwhchung

Approving edit suggestions.

wwhchung · 2022-06-03T16:18:10Z

Thanks for the suggestion @Pandapip1 commited. :)

blmalone

This is looking great, I've given it a first pass.

EIPS/eip-5131.md

blmalone · 2022-06-03T16:22:00Z

EIPS/eip-5131.md

+Let:
+ - `mainAddress` represent the wallet address we are trying to authenticate or very asset ownership for
+ - `mainENS` represent the reverse lookup ENS string for `mainAddress`
+ - `authAddress` represent the address we want to sign with in lieu of `mainAddress`


Are we going to add any requirement on this being an EOA?

I'd say not (for both authAddress and mainAddress) because we wouldn't gain anything from such a restriction, would we?

On second thought, we shouldn't be restricting it because a smart contract address could be used pretty easily with the right setup.

blmalone · 2022-06-03T16:34:49Z

@wwhchung I'm in favor of having some screenshots included to demonstrate the configuration of authAddress, authENS etc.

EIPS/eip-5131.md

Co-authored-by: lightclient <[email protected]>

wwhchung · 2022-06-14T17:24:38Z

Fwiw, I recall a very similar EIP within the past few months wanting to allow an NFT owner to grant access/authorization over the EIP to multiple other wallets.

Thanks. I didn't see the other EIP when I was looking, and circulating it around the other groups I'm part of (NFT Security Group, ENS, etc.) they haven't encountered it either.

What would the next steps here be? Looking forward to having it merged in

EIPS/eip-5131.md

Co-authored-by: Sam Wilson <[email protected]>

EIPS/eip-5131.md

lightclient · 2022-06-28T15:55:30Z

EIPS/eip-5131.md

+Note that this specification allows for both contract level and client/server side validation of signatures.  It is not limited to smart contracts, which is why there is no proposed external interface definition.
+
+## Rationale
+The proposed specification allows one to link multiple addresses as 'authentication addresses' to a core main address. This is beneficial from a security standpoint (if the authentication address is compromised, the assets held by the main address is not), and convenience (if the authentication address is a simple MetaMask wallet but the main address is a hardware wallet).


So I think this section is reading more like motivation than rationale. I think you should consider moving a fair bit of this content above and focus on answering why certain design decisions were chosen over other decisions here.

Co-authored-by: lightclient <[email protected]>

alexanderattar · 2022-07-05T18:40:42Z

EIPS/eip-5131.md

+## Motivation
+Proving ownership of an asset to a third party application in the Ethereum ecosystem is common. Users frequently sign payloads of data to authenticate themselves before gaining access to perform some operation. However, this method--akin to giving the third party root access to one's main wallet--is both insecure and inconvenient.
+
+*** Examples: ***


This EIP seems highly useful given these examples. At the moment there is a real pain point of holding assets securely while still being able to prove ownership via a hot wallet especially in mobile settings. I'd be excited to see this proposal go through

macmac0726171992 · 2022-07-05T19:01:53Z

Thanks

…

On Wed, 6 Jul 2022, 2:40 am Alexander, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In EIPS/eip-5131.md <#5131 (comment)>: > +author: Wilkins Chung ***@***.***) +discussions-to: https://ethereum-magicians.org/t/eip-5131-ens-subdomain-authentication/9458 +status: Draft +type: Standards Track +category: ERC +created: 2022-06-03 +requires: 137 +--- + +## Abstract +This EIP links one or more signing wallets via Ethereum Name Service Specification ([EIP-137](./eip-137.md)) to prove control and asset ownership of a main wallet. + +## Motivation +Proving ownership of an asset to a third party application in the Ethereum ecosystem is common. Users frequently sign payloads of data to authenticate themselves before gaining access to perform some operation. However, this method--akin to giving the third party root access to one's main wallet--is both insecure and inconvenient. + +*** Examples: *** This EIP seems highly useful given these examples. At the moment there is a real pain point of holding assets securely while still being able to prove ownership via a hot wallet especially in mobile settings. I'd be excited to see this proposal go through — Reply to this email directly, view it on GitHub <#5131 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUWDI4LLUZJKBIJPXLAQYZDVSR6TTANCNFSM5XXGMIPQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Pandapip1

Nit

EIPS/eip-5131.md

Co-authored-by: Pandapip1 <[email protected]>

Pandapip1

This is what is failing Travis CI. As soon as this is fixed, this can be merged!

EIPS/eip-5131.md

Co-authored-by: Pandapip1 <[email protected]>

* Add EIP-603: ENS Auth Linking * rename eip-603 to eip-5131 and remove external links * changing to an ERC * additional context * add refrence implementations * rename * edits as per suggestions * further content edits * grammar fix * short description change * update discussion link * update ref implementation * update with new reference code * format edits * update reference implementation * Update eip-5131.md * add additional code for sample implementation * clean up Abstract and move contents into Motivation * Update eip-5131.md * Update EIPS/eip-5131.md Co-authored-by: Sam Wilson <[email protected]> * edits * Update EIPS/eip-5131.md Co-authored-by: Daniel Tedesco <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: Daniel Tedesco <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: lightclient <[email protected]> * update Specification for EIP-5131 * update Rationale section * improve Motivation section * Update EIPS/eip-5131.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5131.md Co-authored-by: Pandapip1 <[email protected]> Co-authored-by: Sam Wilson <[email protected]> Co-authored-by: Daniel Tedesco <[email protected]> Co-authored-by: lightclient <[email protected]> Co-authored-by: Pandapip1 <[email protected]>

nuel-ikwuoma · 2023-09-07T09:09:46Z

@wwhchung curious to know the state of this EIP, is it still relevent or deprecated?

Add EIP-603: ENS Auth Linking

02fdd31

eth-bot added the newEIPFile label Jun 3, 2022

Pandapip1 suggested changes Jun 3, 2022

View reviewed changes

EIPS/eip-603.md Outdated Show resolved Hide resolved

EIPS/eip-603.md Outdated Show resolved Hide resolved

EIPS/eip-603.md Outdated Show resolved Hide resolved

wwhchung changed the title ~~Add EIP-603: ENS Auth Linking~~ Add EIP-5131: ENS Auth Linking Jun 3, 2022

rename eip-603 to eip-5131 and remove external links

d926f0a

wwhchung added 3 commits June 3, 2022 06:30

changing to an ERC

3e3b45c

additional context

069848e

add refrence implementations

03d63ba

blmalone reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

Pandapip1 reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

rename

31fd495

wwhchung changed the title ~~Add EIP-5131: ENS Auth Linking~~ Add EIP-5131: ENS Subdomain Authentication Jun 3, 2022

edits as per suggestions

d779068

Pandapip1 reviewed Jun 3, 2022

View reviewed changes

wwhchung commented Jun 3, 2022

View reviewed changes

blmalone reviewed Jun 3, 2022

View reviewed changes

further content edits

a24fa63

blmalone reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

blmalone reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

wwhchung added 3 commits June 3, 2022 09:42

grammar fix

e51e8ed

short description change

5676cce

update discussion link

3c70189

blmalone reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

blmalone reviewed Jun 3, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

wwhchung and others added 4 commits June 14, 2022 09:00

Update EIPS/eip-5131.md

b59c292

Co-authored-by: lightclient <[email protected]>

Update EIPS/eip-5131.md

9bd601c

Co-authored-by: lightclient <[email protected]>

Update EIPS/eip-5131.md

7d59810

Co-authored-by: lightclient <[email protected]>

Update EIPS/eip-5131.md

ace2c39

Co-authored-by: lightclient <[email protected]>

SamWilsn reviewed Jun 17, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

EIPS/eip-5131.md Outdated Show resolved Hide resolved

EIPS/eip-5131.md Outdated Show resolved Hide resolved

wwhchung and others added 2 commits June 27, 2022 16:35

Update EIPS/eip-5131.md

8ce77e1

Co-authored-by: Sam Wilson <[email protected]>

Update EIPS/eip-5131.md

1f7f35c

Co-authored-by: Sam Wilson <[email protected]>

poojaranjan mentioned this pull request Jun 28, 2022

EIP editor apprenticeship meeting 20 ethcatherders/EIPIP#145

Closed

lightclient requested changes Jun 28, 2022

View reviewed changes

wwhchung and others added 4 commits June 28, 2022 11:26

Update EIPS/eip-5131.md

0b880a1

Co-authored-by: lightclient <[email protected]>

update Specification for EIP-5131

43f8ba4

update Rationale section

bf02f83

improve Motivation section

c3c8687

alexanderattar reviewed Jul 5, 2022

View reviewed changes

Pandapip1 reviewed Jul 8, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

Update EIPS/eip-5131.md

a9fe2e6

Co-authored-by: Pandapip1 <[email protected]>

Pandapip1 approved these changes Jul 9, 2022

View reviewed changes

Pandapip1 suggested changes Jul 9, 2022

View reviewed changes

EIPS/eip-5131.md Outdated Show resolved Hide resolved

eth-bot added updateEIP and removed newEIPFile labels Jul 9, 2022

eth-bot enabled auto-merge (squash) July 9, 2022 17:36

auto-merge was automatically disabled July 9, 2022 21:18
Head branch was pushed to by a user without write access

Update EIPS/eip-5131.md

a7c605a

Co-authored-by: Pandapip1 <[email protected]>

eth-bot enabled auto-merge (squash) July 9, 2022 21:19

eth-bot merged commit f6db72a into ethereum:master Jul 9, 2022

campionfellin mentioned this pull request Jul 27, 2022

EIP-5131 Support ensdomains/ens-app#1541

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-5131: ENS Subdomain Authentication #5131

Add EIP-5131: ENS Subdomain Authentication #5131

wwhchung commented Jun 3, 2022

eth-bot commented Jun 3, 2022 •

edited

Loading

Pandapip1 left a comment

wwhchung commented Jun 3, 2022

Pandapip1 commented Jun 3, 2022

wwhchung commented Jun 3, 2022

Pandapip1 left a comment

wwhchung left a comment

wwhchung commented Jun 3, 2022

blmalone left a comment

blmalone Jun 3, 2022

cxkoda Jun 6, 2022

blmalone Jun 6, 2022 •

edited

Loading

blmalone commented Jun 3, 2022

wwhchung commented Jun 14, 2022

lightclient Jun 28, 2022

alexanderattar Jul 5, 2022

macmac0726171992 commented Jul 5, 2022 via email

Pandapip1 left a comment

Pandapip1 left a comment

nuel-ikwuoma commented Sep 7, 2023 •

edited

Loading

Add EIP-5131: ENS Subdomain Authentication #5131

Add EIP-5131: ENS Subdomain Authentication #5131

Conversation

wwhchung commented Jun 3, 2022

eth-bot commented Jun 3, 2022 • edited Loading

All tests passed; auto-merging...

(pass) eip-5131.md

Pandapip1 left a comment

Choose a reason for hiding this comment

wwhchung commented Jun 3, 2022

Pandapip1 commented Jun 3, 2022

wwhchung commented Jun 3, 2022

Pandapip1 left a comment

Choose a reason for hiding this comment

wwhchung left a comment

Choose a reason for hiding this comment

wwhchung commented Jun 3, 2022

blmalone left a comment

Choose a reason for hiding this comment

blmalone Jun 3, 2022

Choose a reason for hiding this comment

cxkoda Jun 6, 2022

Choose a reason for hiding this comment

blmalone Jun 6, 2022 • edited Loading

Choose a reason for hiding this comment

blmalone commented Jun 3, 2022

wwhchung commented Jun 14, 2022

lightclient Jun 28, 2022

Choose a reason for hiding this comment

alexanderattar Jul 5, 2022

Choose a reason for hiding this comment

macmac0726171992 commented Jul 5, 2022 via email

Pandapip1 left a comment

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

nuel-ikwuoma commented Sep 7, 2023 • edited Loading

eth-bot commented Jun 3, 2022 •

edited

Loading

blmalone Jun 6, 2022 •

edited

Loading

nuel-ikwuoma commented Sep 7, 2023 •

edited

Loading