Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EIP-712 to Final #5433

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Move EIP-712 to Final #5433

merged 1 commit into from
Aug 11, 2022

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Aug 8, 2022

There have been no comments since Last Call was announced.

@eth-bot eth-bot enabled auto-merge (squash) August 8, 2022 18:31
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 8, 2022

A critical exception has occurred:
Message: pr 5433 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting is a bit wonky, but otherwise LGTM. Since this is a pretty significant EIP, I'm going to hold off from flat-out approving it and will wait for someone else to also signal approval.

@frangio
Copy link
Contributor Author

frangio commented Aug 8, 2022

@Pandapip1 Do you mean the images? I agree but I'm not sure what's the right way to resize them in markdown that will work on the final rendered site. Does anyone else know?

Could also just resize the images and reupload them.

@Pandapip1
Copy link
Member

Pandapip1 commented Aug 9, 2022

Not the images; the spacing in between headers is inconsistent, as well as a few other things. I don't think they result in any issues. No action is needed on your part.

@Pandapip1
Copy link
Member

Please close and re-open this PR to merge it.

@frangio
Copy link
Contributor Author

frangio commented Aug 9, 2022

@Pandapip1 Should I do that before or after author approval? (Note: I'm not author)

@Pandapip1
Copy link
Member

It has been approved.

@frangio frangio closed this Aug 10, 2022
auto-merge was automatically disabled August 10, 2022 13:34

Pull request was closed

@frangio frangio reopened this Aug 10, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 10, 2022 13:34
@Pandapip1
Copy link
Member

CC @recmo, @LogvinovLeon, @expede

@wschwab
Copy link
Contributor

wschwab commented Aug 11, 2022

I only noticed that 712 made Last Call now - I had originally written a resolution to the checklist that originally was put in the Security Considerations, which I think is removed in this version of 712. Would I be able to put it back in?

Reference: #4383

@eth-bot eth-bot merged commit c2e19a6 into ethereum:master Aug 11, 2022
@frangio
Copy link
Contributor Author

frangio commented Aug 11, 2022

@wschwab We discussed that section in #5271 (comment) with the editors and agreed that it felt out of place in the EIP as it was more of an implementation log.

Pandapip1 pushed a commit to Pandapip1/EIPs that referenced this pull request Aug 16, 2022
@frangio frangio deleted the 712-finally branch August 17, 2022 18:06
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants