-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move EIP-712 to Final #5433
Move EIP-712 to Final #5433
Conversation
A critical exception has occurred: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting is a bit wonky, but otherwise LGTM. Since this is a pretty significant EIP, I'm going to hold off from flat-out approving it and will wait for someone else to also signal approval.
@Pandapip1 Do you mean the images? I agree but I'm not sure what's the right way to resize them in markdown that will work on the final rendered site. Does anyone else know? Could also just resize the images and reupload them. |
Not the images; the spacing in between headers is inconsistent, as well as a few other things. I don't think they result in any issues. No action is needed on your part. |
Please close and re-open this PR to merge it. |
@Pandapip1 Should I do that before or after author approval? (Note: I'm not author) |
It has been approved. |
CC @recmo, @LogvinovLeon, @expede |
I only noticed that 712 made Last Call now - I had originally written a resolution to the checklist that originally was put in the Security Considerations, which I think is removed in this version of 712. Would I be able to put it back in? Reference: #4383 |
@wschwab We discussed that section in #5271 (comment) with the editors and agreed that it felt out of place in the EIP as it was more of an implementation log. |
There have been no comments since Last Call was announced.