-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: fix index.html issues #5572
Conversation
Doesn't need manual merge, can be approved, and will auto-merge. |
A critical exception has occurred: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing the relative links? Aren't both styles equivalent?
Why are we changing the example EIPs?
If index.html gets renamed or used as a template, then the links will break. Using this style means that other files can be based on or include index.html. It also has better tooling support.
The example EIPs were not final. |
I believe that unless the first character is a slash, both |
That's the problem. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
* Website: fix index.html issues * At some point this should be converted to markdown...
No description provided.