Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: fix index.html issues #5572

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Website: fix index.html issues #5572

merged 2 commits into from
Sep 30, 2022

Conversation

Pandapip1
Copy link
Member

No description provided.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner September 1, 2022 12:01
@Pandapip1
Copy link
Member Author

Doesn't need manual merge, can be approved, and will auto-merge.

@eth-bot
Copy link
Collaborator

eth-bot commented Sep 1, 2022

A critical exception has occurred:
Message: pr 5572 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the relative links? Aren't both styles equivalent?

Why are we changing the example EIPs?

@Pandapip1
Copy link
Member Author

Pandapip1 commented Sep 7, 2022

Why are we changing the relative links? Aren't both styles equivalent?

If index.html gets renamed or used as a template, then the links will break. Using this style means that other files can be based on or include index.html. It also has better tooling support.

Why are we changing the example EIPs?

The example EIPs were not final.

@SamWilsn
Copy link
Contributor

Why are we changing the relative links? Aren't both styles equivalent?

If index.html gets renamed or used as a template, then the links will break.

I believe that unless the first character is a slash, both ./index.html and index.html are resolved relative to the current base URL. I could entirely be mistaken. I think this is the relevant section of the spec.

@Pandapip1
Copy link
Member Author

resolved relative to the current base URL

That's the problem. If index.html gets copied to foo.html, then foo.html will need to change all its links, due to the way that jekyll paths work (foo.html -> /foo).

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@eth-bot eth-bot enabled auto-merge (squash) September 30, 2022 19:07
@eth-bot eth-bot merged commit 7be7402 into master Sep 30, 2022
@eth-bot eth-bot deleted the Pandapip1-website-issues branch September 30, 2022 19:07
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Website: fix index.html issues

* At some point this should be converted to markdown...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants