-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-1: Fix Backward Compatibility Typos #5680
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-1.md
(fail) eip-template.md
|
I think they're both acceptable, and prefer the option that doesn't require changing |
Should we add a [sic] then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is the more accepted form, both are technically correct. I think that it's best to leave as-is so that we don't need to change 5000+ EIPs and eipw.
Every spell checker I've used disagrees. I can change the 5000+ files if need be. I think we can also just keep the old files as having the old form until they are changed. I volunteer to try to fix eipw. |
I am ok ether way. I just hope it be consistent across the board.... |
There are <1000 EIPs, and it's possible to automate this in a few minutes (see my change with the LICENSE file) |
@SamWilsn and I have both expressed that we do not want to pursue this change. |
This has been bugging me for a while. Thoughts?