Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5679 Add Ref Impl #5739

Merged
merged 15 commits into from
Oct 2, 2022
Merged

Update EIP-5679 Add Ref Impl #5739

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3141ce5
init
xinbenlv Sep 18, 2022
291b729
Update ERC number
xinbenlv Sep 18, 2022
b286143
Add content
xinbenlv Sep 18, 2022
748a143
Add discussion-to
xinbenlv Sep 18, 2022
29c6726
Add ERC-165 identifiers
xinbenlv Sep 18, 2022
6c9472c
Change public to external
xinbenlv Sep 18, 2022
613f678
Update with batch and safe methods and add rationale.
xinbenlv Sep 18, 2022
9131562
Fix format
xinbenlv Sep 18, 2022
c38b4eb
Fix EIPW errors
xinbenlv Sep 18, 2022
ea8155c
Add mentioning of EIP-777
xinbenlv Sep 18, 2022
86c3306
Add refimpl for Ext20
xinbenlv Oct 2, 2022
0d88b01
Merge with review
xinbenlv Oct 2, 2022
c24ec3d
Fix
xinbenlv Oct 2, 2022
aca7631
update
xinbenlv Oct 2, 2022
c6a990c
Update
xinbenlv Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion EIPS/eip-5679.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ convention of EIP-721 and EIP-1155 respectively.

This EIP is designed to be compatible for EIP-20, EIP-721 and EIP-1155 respectively.

## Reference Implementation

A few reference implementations of this EIP has been deployed onto goerli (ethereum public testnet).

- Interface `IERC5679Ext20` is deployed onto goerli:0x672cf368Bf6c80517B43A83dD06A4041d7eD6C5E, see verified code on etherscan.

## Security Considerations

This EIP depends on the security soundness of the underlying book keeping behavior of the token implementation.
Expand All @@ -109,7 +115,7 @@ The burning should also carefully design the access control. Typically only the
- Role 1. The current token holder
- Role 2. An role with special privilege.

Either Role 1 OR Role 2 or a consensus between the two are entitled to conduct the burning action.
Either Role 1 OR Role 2 or a consensus between the two are entitled to conduct the burning action.
However as author of this EIP we do recognize there are potentially other use case where a third type of role shall be entitled
to burning. We keep this EIP less opinionated in such restriction but implementors should be cautious about designing
the restriction.
Expand Down