Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-2612: fix misplaced bracket #7077

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Update EIP-2612: fix misplaced bracket #7077

merged 4 commits into from
Jun 1, 2023

Conversation

zakrad
Copy link
Contributor

@zakrad zakrad commented May 26, 2023

@zakrad zakrad requested a review from eth-bot as a code owner May 26, 2023 07:33
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels May 26, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 26, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label May 26, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 26, 2023
Pandapip1
Pandapip1 approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Since this seems like an obvious typo, I'll add it to the manual merge queue.

@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone May 27, 2023
@github-actions
Copy link

The commit 39e8f97 (as a parent of 45ed361) contains errors.
Please inspect the Run Summary for details.

@poojaranjan poojaranjan mentioned this pull request May 30, 2023
Closed
5 tasks
SamWilsn
SamWilsn approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still need author approval.

@SamWilsn SamWilsn added a-review Waiting on author to review and removed e-consensus Waiting on editor consensus labels May 31, 2023
@MrChico
Copy link
Member

MrChico commented May 31, 2023

thanks!

@eth-bot eth-bot added e-consensus Waiting on editor consensus and removed a-review Waiting on author to review labels May 31, 2023
@eth-bot eth-bot enabled auto-merge (squash) May 31, 2023 20:43
eth-bot
eth-bot approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@SamWilsn SamWilsn disabled auto-merge June 1, 2023 15:38
@SamWilsn SamWilsn merged commit 9ba7e4c into ethereum:master Jun 1, 2023
alcedo pushed a commit to StraitsX/EIPs that referenced this pull request Jun 13, 2023
@zakrad @asdfgh @alcedo
Update EIP-2612: fix misplaced bracket (ethereum#7077)
34fa251 
* Update eip-2612.md

* Update eip-2612.md

---------

Co-authored-by: zakrad <[email protected]>
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@zakrad @asdfgh
Update EIP-2612: fix misplaced bracket (ethereum#7077)
e3b00fc 
* Update eip-2612.md

* Update eip-2612.md

---------

Co-authored-by: zakrad <[email protected]>
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@zakrad @asdfgh @RaphaelHardFork
Update EIP-2612: fix misplaced bracket (ethereum#7077)
3129159 
* Update eip-2612.md

* Update eip-2612.md

---------

Co-authored-by: zakrad <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@zakrad @asdfgh @GAEAlimited
Update EIP-2612: fix misplaced bracket (ethereum#7077)
87b9c23 
* Update eip-2612.md

* Update eip-2612.md

---------

Co-authored-by: zakrad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrChico MrChico MrChico approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-erc w-ci Waiting on CI to pass
Projects
None yet
Milestone
Manual Merge Queue
Development

Successfully merging this pull request may close these issues.
6 participants
@zakrad @eth-bot @MrChico @Pandapip1 @SamWilsn @asdfgh