Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: Move to Review #7996

Closed
wants to merge 2 commits into from
Closed

Conversation

arein
Copy link

@arein arein commented Nov 29, 2023

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@arein arein requested a review from eth-bot as a code owner November 29, 2023 11:50
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-interface labels Nov 29, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 29, 2023

File EIPS/eip-5792.md

Requires 1 more reviewers from @axic, @lightclient, @Pandapip1, @SamWilsn

@arein arein changed the title feat: update feat: update guidance on how wallets can advertise support Nov 29, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Nov 29, 2023
@eth-bot eth-bot changed the title feat: update guidance on how wallets can advertise support Update EIP-5792: Move to Review Nov 29, 2023
Copy link

The commit 2986a41 (as a parent of d09558c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 29, 2023
type: Standards Track
category: Interface
created: 2022-10-17
requires: CAIP-25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we don't allow links to CAIPs. If you'd like to propose allowing links to CAIPs, please open a pull request to EIP-1 following the guidelines in EIP-5757

@SamWilsn
Copy link
Contributor

You'll just need to fix the issues identified by eipw and remove that external link.

@bumblefudge
Copy link
Contributor

I think we can close this since #8392 and #8396 merged in the same ideas.

Copy link

github-actions bot commented May 9, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 9, 2024
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-review This EIP is in Review t-interface w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants