Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7568: Move to Review #8048

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Update EIP-7568: Move to Review #8048

merged 7 commits into from
Feb 6, 2024

Conversation

timbeiko
Copy link
Contributor

No description provided.

@timbeiko timbeiko requested a review from eth-bot as a code owner December 20, 2023 20:54
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-meta labels Dec 20, 2023
@timbeiko timbeiko mentioned this pull request Dec 20, 2023
Merged
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 20, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Dec 20, 2023
@eth-bot eth-bot changed the title Move to Review Update EIP-7568: Move to Review Dec 20, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 20, 2023
@poojaranjan poojaranjan mentioned this pull request Dec 26, 2023
Closed
17 tasks
@SamWilsn
Copy link
Contributor

SamWilsn commented Jan 9, 2024

This'll have to wait until 2070 is withdrawn (or you can remove the reference to it.)

@github-actions GitHub Actions
Copy link

The commit 93b4310 (as a parent of 724ccb6) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 5, 2024
@timbeiko
Copy link
Contributor Author

timbeiko commented Feb 5, 2024 •
edited
Loading

@SamWilsn I've done the thing, 2070 is gone. I think we can merge this. Will move it to Last Call after and unless #8028 gets merged before the end of the Last Call period, I'll finalize it without the reference.

@poojaranjan poojaranjan mentioned this pull request Feb 6, 2024
Closed
21 tasks
@eth-bot eth-bot enabled auto-merge (squash) February 6, 2024 15:39
eth-bot
eth-bot approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 84653b8 into ethereum:master Feb 6, 2024
10 checks passed
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 7568 state from Draft to Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gemk83 Gemk83 Gemk83 approved these changes

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@abcoathup abcoathup abcoathup approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timbeiko @eth-bot @SamWilsn @eip-automerger @abcoathup @Gemk83