Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2537: Rollback and fix formula #8437

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

marioevz
Copy link
Member

Rollbacks change in #8414 and actually fixes the conflicting formula.

After speaking with @MariusVanDerWijden, it seems like the duplicated formula to fix was 23000*k + 115000 -> 43000*k + 65000, not the other way around as the previous PR implemented.

@marioevz marioevz requested a review from eth-bot as a code owner April 15, 2024 16:51
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Apr 15, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 15, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Apr 15, 2024
@MariusVanDerWijden
Copy link
Member

Yep the formula was modified here: #3077 but one of the occurrences was missed. Both Geth and Erigon have implemented the new formula

@eth-bot eth-bot enabled auto-merge (squash) April 15, 2024 19:03
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ce2149a into ethereum:master Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants