Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7702: Remove old note about universal cross-chain deployment #8909

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Sep 26, 2024

While it's true that EIP-7702 can commit to deploy code without commiting to fee parameters, it doesn't solve universal cross-chain deployment because the code being deployed must be specified and signed over as an address where it is already (or will be) deployed, i.e. a universal cross-chain address has to be presumed.

Alternative

An alternative change that would solve universal cross-chain deployment would be this:

 At the start of executing the transaction, after incrementing the sender's nonce, for each
 `[chain_id, address, nonce, y_parity, r, s]` tuple do the following:

 1. Verify the chain id is either 0 or the chain's current ID.
-2. `authority = ecrecover(keccak(MAGIC || rlp([chain_id, address, nonce])), y_parity, r, s]`
+2. `authority = ecrecover(keccak(MAGIC || rlp([chain_id, code_hash, nonce])), y_parity, r, s]`,
+    where `code_hash` is the keccak256 hash of the code of `address`.

However, this requires reading the code at address which so far is not done during EIP-7702 auth list validation, and pricing would need to be updated to reflect that. In practice I don't think the cost of using EIP-7702 would increase significantly because the address would also be accessed during execution of the transaction.

@frangio frangio requested a review from eth-bot as a code owner September 26, 2024 14:17
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Sep 26, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 26, 2024

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot added the a-review Waiting on author to review label Sep 26, 2024
@eth-bot eth-bot enabled auto-merge (squash) October 16, 2024 17:10
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@lightclient lightclient disabled auto-merge October 16, 2024 17:10
@lightclient lightclient merged commit 9ab44b9 into ethereum:master Oct 16, 2024
11 checks passed
@frangio frangio deleted the 7702-universal-deploy branch October 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants