Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-658: fix grammar #8923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update EIP-658: fix grammar #8923

wants to merge 1 commit into from

Conversation

RenanSouza2
Copy link
Contributor

@RenanSouza2 RenanSouza2 commented Oct 2, 2024 •
edited
Loading

In this PR one grammar mistake is fixed

@RenanSouza2 RenanSouza2 requested a review from eth-bot as a code owner October 2, 2024 14:43
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Oct 2, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 2, 2024 •
edited
Loading

File EIPS/eip-658.md

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Oct 2, 2024
@eth-bot eth-bot changed the title fix grammar Update EIP-658: fix grammar Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

The commit 0f7d251 (as a parent of 50f1a9c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 2, 2024
@poojaranjan poojaranjan mentioned this pull request Oct 16, 2024
Closed
16 tasks
SamWilsn
SamWilsn requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this isn't "if and only if"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn requested changes

@GIgako19929 GIgako19929 GIgako19929 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RenanSouza2 @eth-bot @SamWilsn @GIgako19929