Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7702: add s value check #8950

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update EIP-7702: add s value check #8950

merged 1 commit into from
Oct 10, 2024

Conversation

lightclient
Copy link
Member

adding back since it was removed by mistake.

@lightclient lightclient requested a review from eth-bot as a code owner October 10, 2024 14:21
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 10, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 10, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title 7702: add s value check Update EIP-7702: add s value check Oct 10, 2024
@eth-bot eth-bot enabled auto-merge (squash) October 10, 2024 14:22
eth-bot
eth-bot approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3e0aee3 into ethereum:master Oct 10, 2024
15 of 16 checks passed
jochem-brouwer
jochem-brouwer approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have also checked if it was less than or less than or equal to than secp256k1/2. It is the latter. So it is correct :)

@marioevz marioevz mentioned this pull request Oct 10, 2024
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightclient @eth-bot @jochem-brouwer